Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 358 #360

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix issue 358 #360

merged 1 commit into from
Jul 22, 2024

Conversation

sildater
Copy link
Member

fixes a bug in get_time_maps_from_alignment where arrays of idx is cast to numpy dtype objects if all score and performance idx are unique. The problem is fixed by not using numpy.

@sildater sildater added the bug Something isn't working label Jul 19, 2024
@sildater sildater linked an issue Jul 19, 2024 that may be closed by this pull request
@manoskary manoskary self-requested a review July 19, 2024 10:18
@sildater sildater linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment for pre-existing code.

partitura/musicanalysis/performance_codec.py Show resolved Hide resolved
@sildater sildater merged commit d366f60 into develop Jul 22, 2024
3 checks passed
@sildater sildater mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does pt.save_match work? Empty note array to piano roll leads to ValueError on empty sequence.
2 participants