Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for Release 1.4.1 #335

Merged
merged 26 commits into from
Oct 25, 2023
Merged

PR for Release 1.4.1 #335

merged 26 commits into from
Oct 25, 2023

Conversation

fosfrancesco
Copy link
Member

Bug Fixes

  • remove unnecessary escape character for correct parsing of sharp accidentals in nakamura match files.
  • don't consider the propriety doc_order for sorting notes in the matchfile_from_alignment function if it is not present. This propriety is only present in parts from musicxml scores and previously resulted in an exception for other score formats. This solves doc_order requirement in export_match #326
  • during matchfile parsing, voice info is now parsed as follows: If there is no voice info, all notes get assigned voice number 1. If there is only voice info for the solo voice, the non-solo voiced notes get voice 2. If multiple notes have different voices, but not every note has a voice annotated, those with voice annotation get the annotated voice number and those without voice annotation get assigned the max voice+1 voice number. Previously all notes were assigned to voice 1 if there were any None voiced note
  • during matchfile parsing, all note classes are now matched correctly. Previously classes MatchSnoteTrailingScore and MatchSnoteNoPlayedNote were always marked as MatchSnoteDeletion and MatchHammerBounceNote, MatchTrailingPlayedNote, MatchTrillNote always ended up as MatchInsertionNote. This solves Trill notes are not parsed as such from match v0 #286
  • during matchfile parsing, lines which can't be parsed are removed. Before they ended up as None in the output.

Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses the latest minor release. I have some minor recommendations and comments left for correction.

partitura/io/importmatch.py Outdated Show resolved Hide resolved
partitura/io/importmatch.py Show resolved Hide resolved
partitura/io/importmatch.py Show resolved Hide resolved
partitura/io/importmatch.py Show resolved Hide resolved
partitura/io/matchfile_base.py Outdated Show resolved Hide resolved
partitura/io/matchfile_base.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
partitura/io/exportmatch.py 79.79% <100.00%> (ø)
partitura/io/importmatch.py 82.27% <100.00%> (-0.79%) ⬇️
partitura/io/importnakamura.py 85.71% <100.00%> (ø)
partitura/io/matchfile_utils.py 94.89% <100.00%> (+0.01%) ⬆️
partitura/io/matchlines_v0.py 86.14% <100.00%> (+0.24%) ⬆️
partitura/io/matchfile_base.py 94.94% <88.88%> (+0.10%) ⬆️
tests/test_match_import.py 99.85% <66.66%> (-0.15%) ⬇️

📢 Thoughts on this report? Let us know!.

@manoskary manoskary self-requested a review October 25, 2023 10:40
Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes minor fixes. Everything looks good.

@fosfrancesco fosfrancesco merged commit 8812ca6 into main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants