-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for Release 1.4.1 #335
PR for Release 1.4.1 #335
Conversation
bug fix for nakamura match file parsing
handle none type doc order
matchfile v1.0.0 voice parsing fix
fix pattern checking
solution without dummies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR addresses the latest minor release. I have some minor recommendations and comments left for correction.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR includes minor fixes. Everything looks good.
Bug Fixes
doc_order
for sorting notes in thematchfile_from_alignment
function if it is not present. This propriety is only present in parts from musicxml scores and previously resulted in an exception for other score formats. This solves doc_order requirement in export_match #326MatchSnoteTrailingScore
andMatchSnoteNoPlayedNote
were always marked asMatchSnoteDeletion
andMatchHammerBounceNote
,MatchTrailingPlayedNote
,MatchTrillNote
always ended up asMatchInsertionNote
. This solves Trill notes are not parsed as such from match v0 #286None
in the output.