-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice parsing fix for bug #267 #329
Conversation
Thanks for looking into this! this PR has several problems:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't work yet. not automatically tested. removes potentially used functionality.
The tests were not launched because the initial push was made for the main branch and then changed, an additional commit even an empty one, has to be made to launch the tests. I will do that. |
Removed a space to launch tests. No code edit was made.
Thanks! What I meant is the functionality in the PR is not addressed in a unittest. |
Fixes bug #267 for voice parsing from match files