Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.0 #268

Merged
merged 165 commits into from
Jun 10, 2023
Merged

Release 1.3.0 #268

merged 165 commits into from
Jun 10, 2023

Conversation

manoskary
Copy link
Member

New Release 1.3.0 (major)

This PR addresses release 1.3.0, it includes several bug fixes, code cleaning, documentation, and new functionality.

New Features

  • Enhanced Performance features in the same fashion as the note features;
  • Fixed-size option for Note features. Use: `
  • Create a score from a note array functionality. Call partitura.musicanalysis.scorify(note_array);

New Optional Features

  • If music21 is installed : Import music21 to Partitura by calling partitura.load_music21(m21_score)
  • If MidiTok is installed : Export Partitura Score to Tokens by calling partitura.utils.music.tokenize(score_data, tokenizer)

Bug Fixes

Other Changes

  • Minor Changes to the Documentation
  • Addition of Docs link to the Github header
  • Upgraded python version requirements to Python>= 3.7

manoskary and others added 30 commits May 25, 2022 19:15
…ray_to_part

# Conflicts:
#	partitura/utils/music.py
# Conflicts:
#	partitura/io/importmidi.py
#	partitura/utils/music.py
#	tests/test_note_array.py
# Conflicts:
#	partitura/io/importmidi.py
#	partitura/utils/music.py
#	tests/test_note_array.py
…note_array_to_part

� Conflicts:
�	partitura/utils/music.py
�	tests/test_note_array.py
@manoskary manoskary self-assigned this Jun 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch coverage: 79.05% and project coverage change: +0.32 🎉

Comparison is base (9834601) 85.00% compared to head (ef54c5a) 85.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   85.00%   85.33%   +0.32%     
==========================================
  Files          72       79       +7     
  Lines       12653    13561     +908     
==========================================
+ Hits        10756    11572     +816     
- Misses       1897     1989      +92     
Impacted Files Coverage Δ
partitura/io/importmei.py 95.62% <ø> (ø)
partitura/io/importmidi.py 83.94% <ø> (ø)
tests/test_mei.py 99.49% <ø> (ø)
partitura/io/importmatch.py 80.30% <14.28%> (-1.77%) ⬇️
partitura/utils/normalize.py 19.51% <19.51%> (ø)
partitura/musicanalysis/note_features.py 63.72% <49.01%> (-6.53%) ⬇️
partitura/utils/music.py 74.20% <69.23%> (+0.01%) ⬆️
partitura/musicanalysis/note_array_to_score.py 77.22% <77.22%> (ø)
partitura/musicanalysis/performance_features.py 83.90% <83.90%> (ø)
tests/test_utils.py 95.14% <85.45%> (-2.87%) ⬇️
... and 20 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manoskary
Copy link
Member Author

manoskary commented Jun 9, 2023

Problem in uniformity:
Function call partitura.musicanalysis.make_note_features is not the same structure as partitura.musicanalysis.compute_performance_features

Should I change this?

fosfrancesco
fosfrancesco previously approved these changes Jun 9, 2023
fosfrancesco
fosfrancesco previously approved these changes Jun 9, 2023
huispaty
huispaty previously approved these changes Jun 9, 2023
@manoskary manoskary dismissed stale reviews from huispaty and fosfrancesco via ef54c5a June 9, 2023 18:02
@manoskary manoskary merged commit 2f20289 into main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants