Skip to content

Commit

Permalink
Merge pull request #373 from CPJKU/import_lakh
Browse files Browse the repository at this point in the history
estimate_voice_info now default to false
  • Loading branch information
sildater authored Sep 24, 2024
2 parents 8dccc0a + d401dcb commit 13e0ced
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions partitura/io/importmidi.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def load_score_midi(
filename: Union[PathLike, mido.MidiFile],
part_voice_assign_mode: Optional[int] = 0,
quantization_unit: Optional[int] = None,
estimate_voice_info: bool = True,
estimate_voice_info: bool = False,
estimate_key: bool = False,
assign_note_ids: bool = True,
) -> score.Score:
Expand Down Expand Up @@ -363,10 +363,8 @@ def load_score_midi(
the MIDI file.
estimate_voice_info : bool, optional
When True use Chew and Wu's voice separation algorithm [2]_ to
estimate voice information. This option is ignored for
part/voice assignment modes that infer voice information from
the track/channel info (i.e. `part_voice_assign_mode` equals
1, 3, 4, or 5). Defaults to True.
estimate voice information. If the voice information was imported
from the file, it will be overridden. Defaults to False.
Returns
-------
Expand Down Expand Up @@ -524,6 +522,8 @@ def load_score_midi(
warnings.warn("pitch spelling")
spelling_global = analysis.estimate_spelling(note_array)



if estimate_voice_info:
warnings.warn("voice estimation", stacklevel=2)
# TODO: deal with zero duration notes in note_array.
Expand Down

0 comments on commit 13e0ced

Please sign in to comment.