-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to specify MOM6 version requirements and configuration #90
Conversation
closes #87
Just thought I'd get your opinion as to whether this approach makes sense. The package itself doesn't care about the version used (afaik) but the demo notebooks do |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 61.02% 61.02%
=======================================
Files 3 3
Lines 544 544
=======================================
Hits 332 332
Misses 212 212 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Navid C. Constantinou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fair point!
Then let's be a bit more specific.
- Let's avoid "as of January 2024". These statements become outdated... The commit anyway comes with a timestamp so everyone knows when the latest README was written.
- Let's not say which versions won't work, e.g., "the source code from here will not necessarily work."
- Let's just say which versions work. E.g., "`regional-mom6 requires you to build mom6 executable from commit XXX"
Also regarding:
Do we know for sure that it should work for coupled or ocean only configurations? Have we ever tested it? Let's not hypothesise if not. It's cleaner if we say
Also, what is the difference of "coupled" and "coupled MOM6-SIS2"? |
I'd rather not do this as it'll clutter up the readme a lot given there are many required packages. The link to my repo and the |
Yes but if we update another part of the readme then the timestamp will change and readers shouldn't then assume that the 'latest' source code refers to that timestamp. I think this way is clearest for now, especially with the link to the |
I only meant to write explicitly the versions of dependencies that cannot be properly added as package dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I only now realized that your repo listed all the commits used to compile MOM6 and its subcomponents.
I rephrased a bit. I think it's good now! It provides the info needed!
Co-authored-by: Navid C. Constantinou <[email protected]>
closes #87