Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #24: don't use FindNetCDF #27

Closed
wants to merge 3 commits into from
Closed

Fix #24: don't use FindNetCDF #27

wants to merge 3 commits into from

Conversation

aekiss
Copy link
Contributor

@aekiss aekiss commented Aug 27, 2019

See #24
Directly specify netcdff as a linked library rather than using FindNetCDF.make, which doesn't work on raijin.
This change relies instead on the module load machinery, so reduces portability of the code.

@benmenadue benmenadue mentioned this pull request Aug 27, 2019
Closed
@aekiss
Copy link
Contributor Author

aekiss commented Sep 20, 2019

This should probably be made more portable as per Ben's suggestion #24 (comment)

@nichannah
Copy link
Contributor

I have created an merged another pull request which superceded this one and follows @aekiss suggestion about #24

@nichannah nichannah closed this Sep 23, 2019
@aekiss aekiss deleted the 24-netcdf-not-found branch December 6, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aekiss @nichannah