Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tutorial to use intake #502

Merged
merged 8 commits into from
Mar 1, 2025
Merged

Conversation

AndyHoggANU
Copy link
Contributor

This PR updates the COSIMA Cookbook Beginner Tutorial and addresses #464.
The tutorial is now intake-ified and cleaned up a little, but other suggestions very welcome.

I've also retained the old tutorial under a different name, but maybe we should delete it altogether (as we really don't want new users adopting the old cookbook).

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@navidcy
Copy link
Collaborator

navidcy commented Mar 1, 2025

Do we need to keep the deprecated cosima_cookbook.getvar tutorial?

@navidcy navidcy added 📔 tutorial 🛸 updating An existing notebook needs to be updated labels Mar 1, 2025
@navidcy navidcy changed the title New tute Convert tutorial to use intake Mar 1, 2025
@AndyHoggANU
Copy link
Contributor Author

Do we need to keep the deprecated cosima_cookbook.getvar tutorial?

I don't think so. Happy for you to make the executive decision to delete.

@navidcy
Copy link
Collaborator

navidcy commented Mar 1, 2025

I'm so happy to delete deprecated stuff. It brings a sensation of liberation.

@adele-morrison
Copy link
Collaborator

Yep I’m all for deleting too! I think we now have intake working with all the mom6 configs and most of the cj50 exps are in intake now too.

@adele-morrison
Copy link
Collaborator

Possibly the only useful thing remaining associated with the cookbook is the explorer tools that I don’t think we have a replacement for yet with intake.

@navidcy
Copy link
Collaborator

navidcy commented Mar 1, 2025

@AndyHoggANU this looks great! I tweaked the language a bit and added cf_xarray to use .sel(longitude=...) instead .sel(xu_ocean=...).

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@AndyHoggANU
Copy link
Contributor Author

Merging - @charles-turner-1 don't worry about the review, but feel free to check it out on Monday.

@AndyHoggANU AndyHoggANU merged commit 0a47562 into COSIMA:main Mar 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📔 tutorial 🛸 updating An existing notebook needs to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants