Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Hovmoller Depth plots #501

Merged
merged 5 commits into from
Mar 1, 2025
Merged

Updating Hovmoller Depth plots #501

merged 5 commits into from
Mar 1, 2025

Conversation

AndyHoggANU
Copy link
Contributor

Updated version of Hovmoller Depth to use intake catalogue and fix an averaging bug.
Might need further tweaks, so I would appreciate a review

@AndyHoggANU AndyHoggANU requested a review from navidcy February 28, 2025 23:22
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@navidcy
Copy link
Collaborator

navidcy commented Mar 1, 2025

I'm confused a bit with this PR. If I go to "Files changes" seems like nothing was changed?

@navidcy
Copy link
Collaborator

navidcy commented Mar 1, 2025

I think we've merged this in #466
So @AndyHoggANU did you somehow opened a new PR from your branch? I think there is no new changed to merge here. Am I right?

@AndyHoggANU
Copy link
Contributor Author

AndyHoggANU commented Mar 1, 2025

I'm confused too - because I thought I had previously submitted this as a PR, but my GitHub fork tells me that I was 4 commits ahead, and it won't let me update to the latest ...

@navidcy
Copy link
Collaborator

navidcy commented Mar 1, 2025

Well you have submitted it...

I'm closing this (We can reopen if needed!).
But we can also zoom and try to sort out your fork? I'm around atm!

@navidcy navidcy closed this Mar 1, 2025
@navidcy navidcy reopened this Mar 1, 2025
@navidcy navidcy merged commit b9ecefb into COSIMA:main Mar 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants