Updated tutorial to cover new method of building datastores #497
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I don't think this PR addresses #480 yet, but I think we could add that in straightforwardly whilst we're working on the same notebook? |
|
I don't think we want to change this until we are directing folks to use |
|
Good question, I don't know - I thought hh5 had already been retired? But yeah, agreed that changing things too early is not ideal. |
| @@ -13,7 +13,10 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
Do we still need "The old way"?
If "the old way" is not suggested anymore let's drop it?
Reply via ReviewNB
There was a problem hiding this comment.
The old method gives people a little more control over the datastore building process, so I think it's worth keeping around. I've reworded things to make that clearer though.
There was a problem hiding this comment.
Assuming this - Great! Let's not call it "Old" and "New" then? Can we give a more descriptive name? comment got into the wrong thread - the changes should be here.
Let me know if you think this clarifies?
| @@ -13,7 +13,10 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks like a misformatted code block in a markdown cell, just pushed what should be a fix
There was a problem hiding this comment.
Yup, fixed.
There was a problem hiding this comment.
Great! Let's not call it "Old" and "New" then? Can we give a more descriptive name?
No description provided.