Intake conversion Atlantic_IndoPacific_Basin_Overturning_Circulation #350
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2024-08-30T05:06:46Z No longer needed - to be deleted. There are also unneeded blank cells on either side of this text. |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2024-08-30T05:06:47Z Would be good to split this cell into a couple of cells to show what ends up in the cat_subset variable |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2024-08-30T05:06:48Z Line #1. cat_subset = catalog[experiment] I don't think re-searching the catalog is necessary... |
|
View / edit / reply to this conversation on ReviewNB marc-white commented on 2024-08-30T05:06:48Z Line #8. atlantic_sector_mask.coords['xt_ocean'] = psi.grid_xt_ocean.values Fails out here: ValueError: cannot add coordinates with new dimensions to a DataArray |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-08-30T05:23:01Z I doubt we need pandas here |
There was a problem hiding this comment.
Instead of having a separate recipe for this I suggest we expand a bit with 1-2 cells the https://cosima-recipes.readthedocs.io/en/latest/Recipes/Meridional_Overturning_Circulation.html recipe. This way it will reduce the amount of maintenance we need. Also everything will be at the same place. Also, the recipe on the meridional overturning circulation has been made model agnostic and use pint for units so we don't need to put more effort in doing that here!
|
Agreed Navid. We already have an issue for this: #435. |
|
I'm closing this then. Let's open a new PR to combine the recipes! |
navidcy
deleted the
INTAKE_Atlantic_IndoPacific_Basin_Overturning_Circulation
branch
Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.
A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.