Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rare double free crash when running in parallel #9

Merged
merged 1 commit into from
May 12, 2023
Merged

fix: rare double free crash when running in parallel #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/another-rxcpp/internal/tools/stream_controller.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ template <typename T> class stream_controller {
serial_type serial_;
unsubscriber_map unsubscribers_;
on_finalizes_t on_finalizes_;
inner(const subscriber_type& sbsc) noexcept : subscriber_(sbsc), serial_(0) {}
inner(subscriber_type sbsc) noexcept : subscriber_(sbsc), serial_(0) {}
};

mutable std::shared_ptr<inner> inner_;
Expand All @@ -36,7 +36,7 @@ template <typename T> class stream_controller {
stream_controller() = delete;

public:
stream_controller(const subscriber_type& subscriber) noexcept {
stream_controller(subscriber_type subscriber) noexcept {
inner_ = std::make_shared<inner>(subscriber);
subscriber.set_on_unsubscribe([inner = inner_]{
stream_controller(inner).finalize();
Expand Down