Refactored Code in public/src/admin/extend/widgets.js to reduce Cognitive Complexity #47 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47
This is a new pull request following PR #48 with modifications including the console.log() as well as a test file in the /tests folder.
The nested if statements and the excessive use of operators within them were driving the cognitive complexity of the forEach function to 16, surpassing the acceptable limit of 15. To address this, I refactored the function by isolating and grouping related conditions into separate, well-defined helper functions, simplifying the main function's logic and improving readability.
This was tested by running npm run lint and npm run test, both passing with no new errors. Test file WidgetsTest.js was written with AI tools.