Refactored code in src/notifications.js to reduce cognitive complexity #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajain-1
commented
Jan 24, 2025
| notification.datetimeISO = utils.toISOString(notification.datetime); | ||
| if (!notification) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This return reduces the complexity of this nested forEach by removing one branch.
ajain-1
commented
Jan 24, 2025
| notifications = mergeIds.reduce((notifications, mergeId) => { | ||
| notifications = mergeIds.reduce(notificationsReducer, notifications); | ||
|
|
||
| function notificationsReducer(notifications, mergeId) { |
There was a problem hiding this comment.
Reduced nesting by making designated functions to reduce the notifications and also to iterate through the differentiators below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
Refactored code in
src/notifications.jsto reduce cognitive complexity by initially un-nesting the code in the foreach loop at line 87. I did this by returning within the loop ifnotificationis null. I also used optional chaining in other parts of the file to resolve some other SonarCloud errors for this file. This is an initial attempt at solving all warnings for this file, and I'll add more commits as necessary.