Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in src/notifications.js to reduce cognitive complexity #9

Open
ajain-1 opened this issue Jan 16, 2025 · 2 comments · May be fixed by #167
Open

Refactoring code in src/notifications.js to reduce cognitive complexity #9

ajain-1 opened this issue Jan 16, 2025 · 2 comments · May be fixed by #167
Assignees
@ajain-1

Comments

@ajain-1
Copy link

ajain-1 commented Jan 16, 2025

Need to refactor the function starting on line 87 to reduce its Cognitive Complexity from 16 to the 15 allowed. There are too many if statements, and also a nested foreach loop, which may be increasing the function's complexity. Reducing the complexity will make this code easier to read and maintain.
@ajain-1
Copy link
Author

ajain-1 commented Jan 16, 2025

I would like to work on this please!

@github-actions GitHub Actions
Copy link

Great! I assigned you (@ajain-1) to the issue. Have fun working on it!

@ajain-1 ajain-1 changed the title Refactoring code in src/notifications.js Refactoring code in src/notifications.js to reduce cognitive complexity Jan 16, 2025
@ajain-1 ajain-1 linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajain-1 ajain-1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored code in src/notifications.js to reduce cognitive complexity ajain-1/NodeBB
1 participant
@ajain-1