Resolve CVE-2015-9284 vulnerability #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make sure that we're mitigating the Cross Site Scripting Forgery vulnerability by using a POST method to initiate the Omniauth flow. For more info: https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284 omniauth/omniauth#809
|
While this mitigates the risk, it unfortunately doesn't get rid of Github's warning. |
|
I was just going to ask! |
|
Ok, I was able to dismiss the security warning via the 'fix has already been started' option. Not sure that's the best approach, but should work for now. I agree, we need better automated checking on PRs. |
nickrobison-usds
approved these changes
Sep 5, 2019
SMLuthi
pushed a commit
that referenced
this pull request
Jun 5, 2020
We need to make sure that we're mitigating the Cross Site Scripting Forgery vulnerability by using a POST method to initiate the Omniauth flow. For more info: https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284 omniauth/omniauth#809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to make sure that we're mitigating the Cross Site Scripting
Forgery vulnerability by using a POST method to initiate the Omniauth
flow. For more info:
https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284
omniauth/omniauth#809
What Changed
postonly with oauth initiation requestspostmethod