Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ndte=240 and other pre release updates #250

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Nov 21, 2018

update CICE version,
set ndte=240,
fix uninitialized forcing field box2001,
update icepack

  • Developer(s): tcraig

  • Are the code changes bit for bit, different at roundoff level, or more substantial? roundoff.

Test results at https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks, hash 0f6f079 shows all tests except boxadv debug pass on conrad with 4 compilers (as expected). 63/67 tests are NOT bit-for-bit as expected (alt01 and boxdyn are bfb). No QC testing done due to confidence in implementation of ndte change.

  • Does this PR create or have dependencies on Icepack or any other models? Uses updated icepack hash but icepack is bit-for-bit.

  • Is the documentation being updated with this PR? (Y/N) Y
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

  • Other Relevant Details:

@apcraig
Copy link
Contributor Author

apcraig commented Nov 21, 2018

Once this is merged, I will run the full "weekend" test suite manually on all platforms to establish new baselines and verify it's working fine on all machines.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialization of cldf looks a little out of place, but that array is unique to this module so it's handled differently from the others. Ok.

@eclare108213 eclare108213 merged commit a1cc9a5 into CICE-Consortium:master Nov 21, 2018
@apcraig
Copy link
Contributor Author

apcraig commented Nov 21, 2018

Thanks for the quick reviews and merge. I have started launched test suites on multiple platforms and will follow up tomorrow.

Regarding the cldf initialization. I agree 100% it's awkward. It's a quick fix to work around a boxdyn debug failure with the cray compiler. I thought about a few other implementations, but decided this was the most direct and least risky. I think with regard to the forcing options, we need to think about what variables should be set by the forcing and if there are some that are not set by some of the forcing options, what should happen. We should probably require that all forcing fields be set to something for each forcing option, even if there is no data. It's also partly why I ran a bunch of tests with the signaling nans today on conrad. I wanted to get an idea of how bad we were with uninitialized variables, see #247. That's probably something we should have done a while ago, but didn't. It's not as bad as I feared, and I think can be deferred until after the release. It looks like the default options are fine and that bgc and box, maybe not surprisingly, need a little work.

@eclare108213
Copy link
Contributor

When we replace the LYq forcing, we might be able to get rid of cldf completely.

@apcraig apcraig deleted the pr60 branch August 17, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants