Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scout): change order of the args #92

Conversation

tjzegmott
Copy link
Contributor

@tjzegmott tjzegmott commented Jun 14, 2024

Description

Changed the order of the arguments to match the order of the other datatrail commands.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Coverage Status

coverage: 67.695% (+0.05%) from 67.645%
when pulling 797eeac on 91-make-the-scout-command-take-the-scope-and-name-in-the-same-order-as-other-commands
into ed5fd1a on main.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (ed5fd1a) to head (797eeac).

Files Patch % Lines
dtcli/scout.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   67.64%   67.69%   +0.05%     
==========================================
  Files          14       14              
  Lines        1227     1232       +5     
==========================================
+ Hits          830      834       +4     
- Misses        397      398       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjzegmott tjzegmott merged commit d5c33b8 into main Jun 14, 2024
2 checks passed
@tjzegmott tjzegmott deleted the 91-make-the-scout-command-take-the-scope-and-name-in-the-same-order-as-other-commands branch June 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the scout command take the scope and name in the same order as other commands
3 participants