Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimisation of imuls|imulu (8,5% faster) #37

Merged
merged 1 commit into from Nov 5, 2016
Merged

optimisation of imuls|imulu (8,5% faster) #37

merged 1 commit into from Nov 5, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2016

No description provided.

@mateoconlechuga mateoconlechuga merged commit c92173f into CE-Programming:master Nov 5, 2016
@adriweb
Copy link
Member

adriweb commented Nov 5, 2016

So hum, Mateo reported that it actually crashes - Why hasn't this been tested [enough] ? :/
I assume grosged was able to come up with benchmarks by having it run correctly, though, so are there any specific conditions for the crash?
In any case, such a function should pass several tests with "standard" values as well as edge cases - and it should at least behave exactly like the old one (unless it fixes a bug of course)

For these kinds of functions, it would really be great to be able to unit-test them automatically, since there's not even a TI ROM needed, actually. But setting that up might be a bit hard/challenging (but it's a good challenge :P)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants