Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<assert.h> depends on <debug.h>, does not include it #14

Closed
elfprince13 opened this issue Feb 6, 2016 · 3 comments
Closed

<assert.h> depends on <debug.h>, does not include it #14

elfprince13 opened this issue Feb 6, 2016 · 3 comments
Labels

Comments

@elfprince13
Copy link
Contributor

It's not great form to have weird include-order issues for client files, especially since <assert.h> is defined by the standard. It should probably include debug.h or something along those lines.

@elfprince13
Copy link
Contributor Author

(n.b. this also means that debug.h should also start by #undef-ing its own macros, since assert.h is required to be able to repeatedly included with different settings w.r.t. NDEBUG.

@adriweb adriweb added the bug label Feb 6, 2016
@mateoconlechuga
Copy link
Member

Bleh

On Sat, Feb 6, 2016 at 12:54 PM, Thomas Dickerson [email protected]
wrote:

(n.b. this also means that debug.h should also start by #undef-ing it's
own macros, since assert.h is required to be able to repeatedly included
with different settings w.r.t. NDEBUG.


Reply to this email directly or view it on GitHub
#14 (comment)
.

@mateoconlechuga
Copy link
Member

Updated release v1.6 to reflect this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants