Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api v2 upgrade #32

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Api v2 upgrade #32

merged 8 commits into from
Dec 5, 2024

Conversation

wkdewey
Copy link
Contributor

@wkdewey wkdewey commented Sep 11, 2024

No description provided.

@wkdewey wkdewey requested review from techgique and removed request for karindalziel October 16, 2024 14:54
Copy link
Member

@techgique techgique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable turbolinks and this PR will be good to go 👍

Gemfile Outdated
# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks
#gem 'turbolinks', '~> 5'
gem 'turbolinks', '~> 5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turbolinks should always be kept disabled. It really messes with the behavior of links and navigating between pages.

@techgique techgique merged commit 6e55c22 into dev Dec 5, 2024
@techgique techgique deleted the api_v2_upgrade branch December 5, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants