Skip to content

Commit

Permalink
Revert concurrent-ruby gem downgrade; fix logger dependency
Browse files Browse the repository at this point in the history
Bad Stack Overflow advice "fixed" this issue, but with other very unwanted consequences

This fix is much better and mirrors how Rails itself fixed the issue
  • Loading branch information
techgique committed Jan 24, 2025
1 parent 823b41b commit 1cad85b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
3 changes: 0 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ gem 'jbuilder', '~> 2.7'
# Reduces boot times through caching; required in config/boot.rb
gem 'bootsnap', '>= 1.4.4', require: false

# Fix for uninitialized constant Logger, see https://stackoverflow.com/questions/79360526/uninitialized-constant-activesupportloggerthreadsafelevellogger-nameerror
gem 'concurrent-ruby', '1.3.4'

group :development, :test do
# Call 'byebug' anywhere in the code to stop execution and get a debugger console
gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
Expand Down
11 changes: 5 additions & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,15 @@ GEM
rack-test (>= 0.6.3)
regexp_parser (>= 1.5, < 3.0)
xpath (~> 3.2)
concurrent-ruby (1.3.4)
concurrent-ruby (1.3.5)
crass (1.0.6)
date (3.4.1)
erubi (1.13.1)
execjs (2.10.0)
ffi (1.17.1)
globalid (1.2.1)
activesupport (>= 6.1)
i18n (1.14.6)
i18n (1.14.7)
concurrent-ruby (~> 1.0)
jbuilder (2.13.0)
actionview (>= 5.0.0)
Expand Down Expand Up @@ -136,7 +136,7 @@ GEM
net-smtp (0.5.0)
net-protocol
nio4r (2.7.4)
nokogiri (1.18.1)
nokogiri (1.18.2)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
public_suffix (6.0.1)
Expand Down Expand Up @@ -191,7 +191,7 @@ GEM
sprockets (> 3.0)
sprockets-rails
tilt
selenium-webdriver (4.27.0)
selenium-webdriver (4.28.0)
base64 (~> 0.2)
logger (~> 1.4)
rexml (~> 3.2, >= 3.2.5)
Expand Down Expand Up @@ -238,7 +238,6 @@ DEPENDENCIES
bootstrap-sass (~> 3.4.1)
byebug
capybara (>= 3.26)
concurrent-ruby (= 1.3.4)
jbuilder (~> 2.7)
jquery-rails (~> 4.3)
listen (~> 3.3)
Expand All @@ -258,4 +257,4 @@ RUBY VERSION
ruby 3.1.6p260

BUNDLED WITH
2.3.27
2.5.23
1 change: 1 addition & 0 deletions config/boot.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)

require "bundler/setup" # Set up gems listed in the Gemfile.
require "logger" # Fix concurrent-ruby removing logger dependency Rails is missing
require "bootsnap/setup" # Speed up boot time by caching expensive operations.

0 comments on commit 1cad85b

Please sign in to comment.