Johanna/6593 fix add patient test execution time #6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobanL
previously approved these changes
Sep 27, 2023
fzhao99
previously approved these changes
Sep 27, 2023
johanna-skylight
dismissed stale reviews from fzhao99 and BobanL
via
1209f06
|
Kudos, SonarCloud Quality Gate passed! |
|
I had to resolved a merge conflicts. I need re-approvals please and thanks! |
fzhao99
approved these changes
Sep 28, 2023
BobanL
approved these changes
Sep 28, 2023
johanna-skylight
deleted the
johanna/6593_fix_add_patient_test_execution_time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FRONTEND PULL REQUEST
Related Issue
Changes Proposed
fireEventin the fill out form method as this is just a pre-step for the actual unit testing and there is no critical need to mock a user's interaction.AddPatientunit testing into multiple files as this is the only way that jest can run them in parallel.QueueItemunit tests to remove the manual pauses using timesouts and check updates in the UI as cues of user actions properly processed.Testing
All unit testing should pass.