Auto-convert dates passed as strings #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
zsusswein
force-pushed
the
zs-autofix-dates
branch
from
8eafe08 to
c254b15
Compare
And print a helpful message when casting the dates. This is a small change, but a nice quality-of-life improvement when specifying the model. This change breaks the pattern of checking & validating with empty returns. I don't love breaking the pattern, but I thought the best alternative would be to fully pull out the validators and have each validator return their input. That might be worth it at some point, but while we're only doing that for the dates I didn't think it was worth it just yet.
zsusswein
force-pushed
the
zs-autofix-dates
branch
from
c254b15 to
5f21ba5
Compare
Agree |
seabbs
approved these changes
Nov 12, 2024
seabbs
pushed a commit
that referenced
this pull request
Nov 16, 2024
* WIP: summary * Broken * Save current status before deleting a bunch of stuff * Pausing here for feedback * Fix missing rlang call * Checkpointing work * All tests passing for date handling * Semi-working r estimation Broke some other stuff along the way that now needs cleanup. Need to handroll the derivative and something is getting weird with the order of magnitude. Not sure what. * That works Had to divide the centered discrete derivative by the magnitude of the change in units of y * Some additional cleanup * Working predict method with docs * Bring all current tests up to passing * Typos * Drop extraneous util Introduced in #67 instead * Add testing for validator * Drop impossible case * Add new integration tests for methods * Once more with the typos * Bump NEWS * Drop obselete function * Typos!!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And print a helpful message when casting the dates. This is a small
change, but a nice quality-of-life improvement when specifying the
model.
This change breaks the pattern of checking & validating with empty
returns. I don't love breaking the pattern, but I thought the best
alternative would be to fully pull out the validators and have each
validator return their input. That might be worth it at some point,
but while we're only doing that for the dates I didn't think it was
worth it just yet.