Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNDE-1880: RTR - Populate RDB_modern with Case Management data #82

Merged
merged 6 commits into from
Nov 18, 2024
Merged

CNDE-1880: RTR - Populate RDB_modern with Case Management data #82

merged 6 commits into from
Nov 18, 2024

Conversation

sveselev
Copy link
Collaborator

@sveselev sveselev commented Nov 13, 2024 •
edited
Loading

Notes

Extract case management data from investigation event, produce nrt_investigation_case_management topic and sink to rdb_modern.

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@sveselev sveselev marked this pull request as ready for review November 14, 2024 19:40
@sveselev
Merge branch 'refs/heads/main' into CNDE-1880-rtr-case-management-to-nrt
c9d2adb 
# Conflicts:
#	investigation-service/src/test/java/gov/cdc/etldatapipeline/investigation/service/InvestigationServiceTest.java
upasanapattnaik-eq
upasanapattnaik-eq approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sveselev sveselev marked this pull request as draft November 14, 2024 19:59
alog-enquizit
alog-enquizit approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@alog-enquizit alog-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sveselev sveselev marked this pull request as ready for review November 18, 2024 16:49
johneipe
johneipe approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@johneipe johneipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sveselev sveselev merged commit 29f9e15 into main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upasanapattnaik-eq upasanapattnaik-eq upasanapattnaik-eq approved these changes

@johneipe johneipe johneipe approved these changes

@alog-enquizit alog-enquizit alog-enquizit approved these changes

@joshua-mills-cdw joshua-mills-cdw Awaiting requested review from joshua-mills-cdw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sveselev @johneipe @alog-enquizit @upasanapattnaik-eq