Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE-1602: SAS to SQL RTR: Migrate CASE_COUNT SAS dimension to SQL #76

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

johneipe
Copy link
Collaborator

@johneipe johneipe commented Nov 8, 2024

Notes

SAS to SQL RTR: Migrating CASE_COUNT SAS dimension to SQL procedures

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the unit test be taken up in a separate ticket?

Copy link
Collaborator

@sveselev sveselev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed unit tests should be fixed (otherwise deployment is not possible)

@johneipe johneipe merged commit 335358a into main Nov 12, 2024
2 checks passed
@sveselev sveselev deleted the CNDE-1602 branch November 12, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants