generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNDE 1402, 1838 #69
Merged
Merged
CNDE 1402, 1838 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-mills-cdw
requested review from
sveselev,
upasanapattnaik-eq,
johneipe and
rseshadri99
October 28, 2024 19:59
upasanapattnaik-eq
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Migrate sp_D_LAB101 into event-based framework.
Remove ODSE dependencies
Review dependencies and any missing dependencies of LAB101.
Some temporary session tables rely on UPDATE statements after creation to set value that can be set at the time of creation using CASE statements instead.
Determine which UPDATE statements can be effectively replaced by CASE statements
Break up “SELECT *” statements where possible to allow for this
Document which UPDATE statements should be left in and why
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle build
pass in your local?gradle build
logs attached?