Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE-1849: Refactor Investigation Service to use Kafka updates for Page Case Answers #66

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

sveselev
Copy link
Collaborator

Notes

This PR improves overall performance by reducing the processing time in the Investigation Service. Direct interactions with RDB database replaces by delete/update via Kafka topic for nrt_page_case_answer.

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

Copy link
Collaborator

@alog-enquizit alog-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
81.8% Coverage on New Code (required ≥ 90%)
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sveselev sveselev merged commit 197cb5c into main Oct 25, 2024
1 of 2 checks passed
@sveselev sveselev deleted the CNDE-1849-refactor-page-case-answers branch October 25, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants