-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNDE-1849: Refactor Investigation Service to use Kafka updates for Page Case Answers #66
Conversation
common-util/src/main/java/gov/cdc/etldatapipeline/commonutil/json/CustomJsonGeneratorImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/gov/cdc/etldatapipeline/investigation/util/ProcessInvestigationDataUtil.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
...e/src/main/java/gov/cdc/etldatapipeline/investigation/util/ProcessInvestigationDataUtil.java
Show resolved
Hide resolved
...ce/src/main/resources/db/rdb_modern/routines/005-sp_nrt_investigation_postprocessing-003.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Notes
This PR improves overall performance by reducing the processing time in the Investigation Service. Direct interactions with RDB database replaces by delete/update via Kafka topic for
nrt_page_case_answer
.JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle build
pass in your local?gradle build
logs attached?