Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

CDCgov / NEDSS-DataReporting Public

generated from CDCgov/template

Notifications You must be signed in to change notification settings
Fork 2
Star 0

Code
Issues
Pull requests 2
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNDE 1393 #60

Merged

joshua-mills-cdw merged 15 commits into main from CNDE-1393

Oct 21, 2024

Merged

CNDE 1393 #60

joshua-mills-cdw merged 15 commits into main from CNDE-1393

Oct 21, 2024

Conversation 13 Commits 15 Checks 0 Files changed

Conversation

Copy link

Collaborator

joshua-mills-cdw commented Oct 17, 2024 •

edited

Loading

Notes

Create sp_d_lab_test_postprocessing to create event based framework for LAB_TEST dimension update/insert.
Remove RDB dependency
Remove ODSE dependency
Remove persisted temporary tables: RDB.dbo.TMP_{}

JIRA

CNDE-1393: [Jira Ticket](url)

Checklist

PR focuses on a single story.
New unit tests added and ensured they pass.
Service has been tested in local and it works as expected.
Documentation has been updated for this code change (if needed).
Code follows the Java Coding Conventions (https://www.oracle.com/java/technologies/javase/codeconventions-programmingpractices.html).

Types of changes

What types of changes does this PR introduces?

Bugfix
New feature
Breaking change

Testing

Does this PR has >90% code coverage?
Is the screenshot attached for code coverage?
Does the gradle build pass in your local?
Is the gradle build logs attached?

Sorry, something went wrong.

All reactions

joshua-mills-cdw added 8 commits

September 25, 2024 11:59


          publish branch

2ba7b73


          sp_d_lab_test_postprocessing sproc

c045f86


          CNDE-1393: remove dependencies and redundant code

900a58b


          CNDE-1393: fixed inconsistencies

7d17b03


          CNDE-1393: added update functionality

07840f1


          Merge branch 'main' of github.com:CDCgov/NEDSS-DataReporting into CND…

78b8ad9

…E-1393


          CNDE-1393: initial sproc commit

b606fb4


          CNDE 1393: updated sproc for rdb_modern

6c26033

joshua-mills-cdw changed the title ~~Cnde 1393~~ CNDE 1393

joshua-mills-cdw marked this pull request as ready for review

October 17, 2024 17:56

joshua-mills-cdw requested review from sveselev, johneipe and upasanapattnaik-eq

October 17, 2024 17:58

joshua-mills-cdw added 2 commits

October 17, 2024 16:31


          CNDE-1393: added transformations to update

f4253bb


          CNDE 1393: updated sproc for rdb_modern

dd61404

CNDE-1393: added transformations to update

CNDE-1393: updated sproc for rdb_modern

upasanapattnaik-eq requested a review from rseshadri99

October 18, 2024 16:53

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq reviewed

View reviewed changes

...e-service/src/main/resources/db/rdb_modern/routines/018-sp_d_lab_test_postprocessing-001.sql Outdated Show resolved Hide resolved

upasanapattnaik-eq requested changes

View reviewed changes

Copy link

Collaborator

upasanapattnaik-eq left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting and database references

Sorry, something went wrong.

All reactions

joshua-mills-cdw added 3 commits

October 21, 2024 12:18


          CNDE-1393: pull latest changes from main

0e5fe45


          Merge branch 'CNDE-1393' of github.com:CDCgov/NEDSS-DataReporting int…

a78ec69

…o CNDE-1393


          CNDE-1393: refactor and format sproc

bd4f13b


          Merge branch 'main' of github.com:CDCgov/NEDSS-DataReporting into CND…

dbc0649

…E-1393

upasanapattnaik-eq reviewed

View reviewed changes

...src/main/resources/db/rdb_modern/routines/015-sp_nrt_morbidity_report_postprocessing-002.sql Outdated Show resolved Hide resolved


          CNDE-1393: refactor and format sproc

0034f8e

upasanapattnaik-eq approved these changes

View reviewed changes

Copy link

Collaborator

upasanapattnaik-eq left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

All reactions

joshua-mills-cdw merged commit 7b5e3a8 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

upasanapattnaik-eq upasanapattnaik-eq approved these changes

sveselev Awaiting requested review from sveselev

johneipe Awaiting requested review from johneipe

rseshadri99 Awaiting requested review from rseshadri99

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.