Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDE-1724: Fix for PAT_BIRTH_COUNTRY being null #50

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

johneipe
Copy link
Collaborator

@johneipe johneipe commented Oct 2, 2024

Notes

DTS1_HEP datamart_PAT_BIRTH_COUNTRY is null when user selects certain countries on the patient tab within the Investigation (NBS UI).
The COUNTRY_CODE tables doesn't have all the codes and hence nrt_patient populates it as null. The sp has been modified to use CODE_VALUE_GENERAL table

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

Copy link
Collaborator

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johneipe johneipe merged commit a9cdc48 into main Oct 4, 2024
@johneipe johneipe deleted the CNDE-1724 branch December 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants