Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue32 #86

Merged
merged 4 commits into from
Feb 13, 2017
Merged

Issue32 #86

merged 4 commits into from
Feb 13, 2017

Conversation

dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Feb 7, 2017

isLatitude and isLongitude now verify that order axes verifications does not return true before accepting the variable as a axis.

@doutriaux1
Copy link
Contributor

@dnadeau4 please add tests

doutriaux1
doutriaux1 suggested changes Feb 8, 2017
View reviewed changes
Copy link
Contributor

@doutriaux1 doutriaux1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need tests

@durack1
Copy link
Member

durack1 commented Feb 9, 2017

@dnadeau4 does this PR provide string support in cdms2/CDUNIF? Or is that another job in the queue?

@dnadeau4
Copy link
Contributor Author

dnadeau4 commented Feb 9, 2017

@durack1 That fixes your lat/lon issues when your units are reversed.

@doutriaux1 doutriaux1 merged commit 068bb93 into master Feb 13, 2017
@doutriaux1 doutriaux1 deleted the issue32 branch February 13, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doutriaux1 doutriaux1 doutriaux1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnadeau4 @doutriaux1 @durack1