-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an onboarding topic-aware user embedder with various embedding sources and strategies #147
Conversation
e59b0b0
to
586e042
Compare
586e042
to
df8fd4b
Compare
@mdekstrand Does the failing "Check data pipeline up-to-date" job here imply that I need to run EDIT: On a related note, how do I select CUDA and optimize CPU parallelism with |
@karlhigley Yes, that's what it means. I'm fine with merging with that check failed, so long as the MIND subset check passes — make sure we can reproduce the pipeline, but maybe we haven't actually done so. I wish there was a way to mark a GitHub action so that its failure is a warning instead of an error — then we could more clearly indicate which checks are mandatory and which checks (so far just this one) are optional. I think it is useful to to know that we've made changes that result in out-of-date pipelines, even if we don't fix that right away, although I'm definitely open to counterarguments there :). To control runs: environment variable |
@mdekstrand Thanks, that helps! It is possible to give containers CUDA access but I don't think our dev containers have that yet. I'll give these settings a go using the Pixi environment though. |
I'm running the |
@karlhigley @Sris-Ty do you know what would be making the tests take so long? |
No—it's been stuck there for quite awhile. Not sure if it's something about the pipelines that join multiple recommenders? |
I cancelled and restarted the job, to see if it was an ephemeral hang, but no. We should stick a timeout on that job, but also figure out what's being slow here. |
The tests run and pass in reasonable time on my macbook. |
In that case, I am hoping joining different recommender is okay as it is taking reasonable time? |
@Sris-Ty I am not sure what you mean. I doubt the joining is the problem, as the tests ran fine on my local machine. I am testing in the devcontainer to see if they fail there. |
The tests also demonstrate this problem in my devcontainer, so it's apparently something that shows up in Linux, not macOS; but is not specific to x86. |
glad we could merge this! |
No description provided.