Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update patch for windows priority with functions #990

Merged
merged 4 commits into from
Jul 17, 2018

Conversation

thetransformerr
Copy link
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}

one of many instances where data is received without any window defined in decoder.
@cfsmp3
Copy link
Contributor

cfsmp3 commented Jul 9, 2018

What specific sample file from your collection can be used to test that this actually solves problems?

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jul 9, 2018

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results:

Report Name Tests Passed
Broken 13/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 21/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 86/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

ccextractor-bot commented Jul 10, 2018

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results:

Report Name Tests Passed
Broken 12/13
DVB 4/7
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Teletext 18/21
WTV 13/13
XDS 34/34
CEA-708 14/14
DVD 3/3
Options 84/86

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Your PR breaks these cases:


Check the result page for more info.

@canihavesomecoffee
Copy link
Member

On Windows, there's an exception:

vcxsrv_2018-07-10_09-10-39

This caused the previous bad results.

@canihavesomecoffee
Copy link
Member

@thetransformerr I'll retrigger the tests this evening, as it seems it's not triggered right now.

@thetransformerr
Copy link
Contributor Author

hi for testing the timing issue , I have used following two videos from this folder:https://drive.google.com/drive/folders/0B_61ywKPmI0Ta2diT3l0eTlHc2c

ANDE.ts
USA.ts

however this change does only remove that error and due to this issue there is not change in timing.

@cfsmp3 cfsmp3 merged commit ef63d61 into CCExtractor:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants