Downgrade ubuntu version in playwright.yml #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arif-Khalid
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Great PR and investigation.
Could you adjust the commit message to be more descriptive since it might be confusing for future developers to see the rollback of ubuntu version without a reason.
You can refer to https://se-education.org/guides/conventions/git.html for a guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1292
Changes Made:
Proposed Commit Message:
Downgrade ubuntu version to v22.04 in playwright.yml
Playwright v1.33~ is incompatible with ubuntu-latest
(v24.x at the point of writing), causing the playwright
workflow to fail at installing browser stage.
Let's fix the ubuntu version to v22.04 (i.e. the latest
compatible ubuntu version).
Note that if we were to upgrade the playwright version
(instead of downgrading ubuntu version), it would
require us to upgrade node version to >= 18, which
is non-trivial.