Build MPI and serial executables in separate build trees #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 68.28% 68.01% -0.27%
==========================================
Files 21 21
Lines 1157 1160 +3
==========================================
- Hits 790 789 -1
- Misses 367 371 +4 ☔ View full report in Codecov by Sentry. |
SeanBryan51
force-pushed
the
build-mpi-and-serial-separately
branch
from
67f8158 to
15077ff
Compare
|
Integration tests passing. |
|
A local benchcab install of this branch successfully runs with CABLE branch |
SeanBryan51
requested review from
a team and
bschroeter
and removed request for
a team
SeanBryan51
commented
Nov 13, 2024
SeanBryan51
force-pushed
the
build-mpi-and-serial-separately
branch
from
15077ff to
e7bb7bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchcab currently fails to install the executables for CABLE-LSM/CABLE#469 due to a change in the structure of the CMakeLists.txt file - namely a single executable is now only built per build tree where as before both serial and MPI executables were built under the same build tree. Whilst this was convenient, it breaks the CMake model of one build configuration per build tree (see PR for more details) and will be hard to maintain with MPI development going forward.
This change adds support for the changes to CMakeLists.txt as part of CABLE-LSM/CABLE#469 by generating two out of source builds for serial and MPI applications instead of one. This change is also backwards compatible for CABLE commits prior to the changes to CMakeLists.txt.