Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging and tests for chdir #260

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Add logging and tests for chdir #260

merged 1 commit into from
Mar 6, 2024

Conversation

abhaasgoyal
Copy link

@abhaasgoyal abhaasgoyal commented Mar 6, 2024

Resolves #161

Merge Message

  • Add DEBUG log message when changing current working directory.
  • Add unit test for chdir functionality, where it only changes directory within context.

@abhaasgoyal abhaasgoyal marked this pull request as ready for review March 6, 2024 04:53
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.72%. Comparing base (ce3608e) to head (5c9c7f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   63.50%   63.72%   +0.21%     
==========================================
  Files          35       35              
  Lines        2521     2536      +15     
==========================================
+ Hits         1601     1616      +15     
  Misses        920      920              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhaasgoyal abhaasgoyal force-pushed the 161-chdir-log-output branch from e3c0145 to 5c9c7f6 Compare March 6, 2024 04:55
@abhaasgoyal abhaasgoyal requested a review from ccarouge March 6, 2024 04:59
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test.

@abhaasgoyal abhaasgoyal merged commit 9ac16aa into main Mar 6, 2024
5 checks passed
@abhaasgoyal abhaasgoyal deleted the 161-chdir-log-output branch March 6, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chdir should output to stdout
2 participants