Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize system binaries over paths set by user #252

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

abhaasgoyal
Copy link

@abhaasgoyal abhaasgoyal commented Feb 13, 2024

Resolves #220

Merge Message

analysis3-unstable had a package named ld whose library search paths were different from system's ld (/usr/bin/ld). This commit ensures that during compilation process, any binaries would be searched in system paths first before conda paths.

Tested with CABLE commit 67a52dc5721f0da78ee7d61798c0e8a804dcaaeb
Environment: Cloned analysis3-unstable and remove benchcab.

@abhaasgoyal abhaasgoyal requested a review from ccarouge February 13, 2024 12:23
@abhaasgoyal abhaasgoyal self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e3f1f9e) 59.65% compared to head (7c8fa5a) 59.61%.
Report is 9 commits behind head on main.

❗ Current head 7c8fa5a differs from pull request most recent head 6706a73. Consider uploading reports for the commit 6706a73 to get more accurate results

Files Patch % Lines
benchcab/benchcab.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   59.65%   59.61%   -0.04%     
==========================================
  Files          30       30              
  Lines        2191     2199       +8     
==========================================
+ Hits         1307     1311       +4     
- Misses        884      888       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhaasgoyal abhaasgoyal force-pushed the 220-build-benchcab-hh5-conda-env branch from d142df5 to ae15b4d Compare February 14, 2024 02:04
@abhaasgoyal abhaasgoyal changed the title Make build step work for hh5 environment Prioritize system binaries over paths set by user Feb 14, 2024
@abhaasgoyal abhaasgoyal force-pushed the 220-build-benchcab-hh5-conda-env branch from ae15b4d to 7c8fa5a Compare February 14, 2024 02:13
@abhaasgoyal abhaasgoyal force-pushed the 220-build-benchcab-hh5-conda-env branch from 7c8fa5a to 6706a73 Compare February 14, 2024 02:31
Copy link
Member

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@abhaasgoyal abhaasgoyal merged commit b560dd8 into main Feb 14, 2024
3 checks passed
@abhaasgoyal abhaasgoyal deleted the 220-build-benchcab-hh5-conda-env branch February 14, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build step fails when running benchcab from the hh5 conda environment
2 participants