-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove svn dependency in default runs #236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 58.23% 58.22% -0.01%
==========================================
Files 29 29
Lines 2114 2109 -5
==========================================
- Hits 1231 1228 -3
+ Misses 883 881 -2 ☔ View full report in Codecov by Sentry. |
5d23acc
to
7e72c2a
Compare
@ccarouge can you run benchcap for comparison on CABLE_AUX? |
Comparison of benchcab with the gridinfo file from CABLE-AUX branch and with a gridinfo file in rp23 has been done. It has shown differences in the results. This is surprising and might require further investigation on the CABLE side later on. To move on here, we will look at adding the CABLE-AUX data under /g/data/wd9 for the moment. This will change once we have a well-documented gridinfo file we can use instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one small change to make before merging. I'm approving because I don't think I need to review again after that change but feel free to ask anyway if you want to.
Once the change is done, you are free to merge (not squash or rebase please).
Fixes #230
Merge Message
When running benchcab, it checks out on svn branch, potentially for data files like
GRID_DATA
. This commit:main
vs230-remove-svn-dependency
branch during integration tests