103 we should be using the logging module

benchcab/__init__.py

@@ -3,10 +3,14 @@
 
 import importlib.metadata
 
+from benchcab.utils import get_logger
+
 try:
     __version__ = importlib.metadata.version("benchcab")
 except importlib.metadata.PackageNotFoundError:
     __version__ = ""
-    print("Warning: unable to interrogate version string from installed distribution.")
+    get_logger().warn(
+        "unable to interrogate version string from installed distribution."
+    )
     # Note: cannot re-raise exception here as this will break pytest
     # when running without first installing the package

benchcab/benchcab.py

@@ -23,9 +23,10 @@
 )
 from benchcab.internal import get_met_forcing_file_names
 from benchcab.model import Model
+from benchcab.utils import get_logger
 from benchcab.utils.fs import mkdir, next_path
 from benchcab.utils.pbs import render_job_script
-from benchcab.utils.repo import SVNRepo, create_repo
+from benchcab.utils.repo import create_repo
 from benchcab.utils.subprocess import SubprocessWrapper, SubprocessWrapperInterface
 from benchcab.workdir import setup_fluxsite_directory_tree
 
@@ -41,13 +42,25 @@
         benchcab_exe_path: Optional[Path],
         validate_env: bool = True,
     ) -> None:
+        """Constructor.
+
+        Parameters
+        ----------
+        benchcab_exe_path : Optional[Path]
+            Path to the executable.
+        validate_env : bool, optional
+            Validate the environment, by default True
+
+        """
         self.benchcab_exe_path = benchcab_exe_path
         self.validate_env = validate_env
 
         self._config: Optional[dict] = None
         self._models: list[Model] = []
         self.tasks: list[Task] = []  # initialise fluxsite tasks lazily
 
+        # Get the logger object
+        self.logger = get_logger()
         self._set_environment()
 
     def _set_environment(self):
@@ -61,13 +74,13 @@
             return
 
         if "gadi.nci" not in internal.NODENAME:
-            print("Error: benchcab is currently implemented only on Gadi")
+            self.logger.error("benchcab is currently implemented only on Gadi")
             sys.exit(1)
 
         namelist_dir = Path(internal.CWD / internal.NAMELIST_DIR)
         if not namelist_dir.exists():
-            print(
-                "Error: cannot find 'namelists' directory in current working directory"
+            self.logger.error(
+                "Cannot find 'namelists' directory in current working directory"
             )
             sys.exit(1)
 
@@ -89,16 +102,16 @@
 
         for modname in modules:
             if not self.modules_handler.module_is_avail(modname):
-                print(f"Error: module ({modname}) is not available.")
+                self.logger.error(f"Module ({modname}) is not available.")
                 sys.exit(1)
 
         system_paths = os.getenv("PATH").split(":")[: len(internal.SYSTEM_PATHS)]
         if set(system_paths) != set(internal.SYSTEM_PATHS):
             msg = f"""Error: System paths are not prioritized over user-defined paths
                     Currently set as: {system_paths}
                     The required system paths are: {internal.SYSTEM_PATHS}
             """
             raise EnvironmentError(msg)
 
         all_site_ids = set(
             internal.MEORG_EXPERIMENTS["five-site-test"]
@@ -107,14 +120,15 @@
         for site_id in all_site_ids:
             paths = list(internal.MET_DIR.glob(f"{site_id}*"))
             if not paths:
-                print(
-                    f"Error: failed to infer met file for site id '{site_id}' in "
-                    f"{internal.MET_DIR}."
+                self.logger.error(
+                    f"Failed to infer met file for site id '{site_id}' in "
                 )
+                self.logger.error(f"{internal.MET_DIR}.")
+
                 sys.exit(1)
             if len(paths) > 1:
-                print(
-                    f"Error: multiple paths infered for site id: '{site_id}' in {internal.MET_DIR}."
+                self.logger.error(
+                    f"Multiple paths infered for site id: '{site_id}' in {internal.MET_DIR}."
                 )
                 sys.exit(1)
 
@@ -145,13 +159,11 @@
         )
         return self.tasks
 
-    def validate_config(self, config_path: str, verbose: bool):
+    def validate_config(self, config_path: str):
         """Endpoint for `benchcab validate_config`."""
         _ = self._get_config(config_path)
 
-    def fluxsite_submit_job(
-        self, config_path: str, verbose: bool, skip: list[str]
-    ) -> None:
+    def fluxsite_submit_job(self, config_path: str, skip: list[str]) -> None:
         """Submits the PBS job script step in the fluxsite test workflow."""
         config = self._get_config(config_path)
         self._validate_environment(project=config["project"], modules=config["modules"])
@@ -160,17 +172,18 @@
             raise RuntimeError(msg)
 
         job_script_path = Path(internal.QSUB_FNAME)
-        print(
-            "Creating PBS job script to run fluxsite tasks on compute "
-            f"nodes: {job_script_path}"
+        self.logger.info(
+            "Creating PBS job script to run fluxsite tasks on compute nodes"
         )
+
+        self.logger.info(f"job_script_path = {job_script_path}")
+
         with job_script_path.open("w", encoding="utf-8") as file:
             contents = render_job_script(
                 project=config["project"],
                 config_path=config_path,
                 modules=config["modules"],
                 pbs_config=config["fluxsite"]["pbs"],
-                verbose=verbose,
                 skip_bitwise_cmp="fluxsite-bitwise-cmp" in skip,
                 benchcab_path=str(self.benchcab_exe_path),
             )
@@ -180,94 +193,89 @@
             proc = self.subprocess_handler.run_cmd(
                 f"qsub {job_script_path}",
                 capture_output=True,
-                verbose=verbose,
             )
         except CalledProcessError as exc:
-            print("Error when submitting job to NCI queue")
-            print(exc.output)
+            self.logger.error("when submitting job to NCI queue, details to follow")
+            self.logger.error(exc.output)
             raise
 
-        print(
-            f"PBS job submitted: {proc.stdout.strip()}\n"
-            "The CABLE log file for each task is written to "
-            f"{internal.FLUXSITE_DIRS['LOG']}/<task_name>_log.txt\n"
-            "The CABLE standard output for each task is written to "
-            f"{internal.FLUXSITE_DIRS['TASKS']}/<task_name>/out.txt\n"
-            "The NetCDF output for each task is written to "
-            f"{internal.FLUXSITE_DIRS['OUTPUT']}/<task_name>_out.nc"
-        )
+        self.logger.info(f"PBS job submitted: {proc.stdout.strip()}")
+        self.logger.info("CABLE log file for each task is written to:")
+        self.logger.info(f"{internal.FLUXSITE_DIRS['LOG']}/<task_name>_log.txt")
+        self.logger.info("The CABLE standard output for each task is written to:")
+        self.logger.info(f"{internal.FLUXSITE_DIRS['TASKS']}/<task_name>/out.txt")
+        self.logger.info("The NetCDF output for each task is written to:")
+        self.logger.info(f"{internal.FLUXSITE_DIRS['OUTPUT']}/<task_name>_out.nc")
 
-    def checkout(self, config_path: str, verbose: bool):
+    def checkout(self, config_path: str):
         """Endpoint for `benchcab checkout`."""
         config = self._get_config(config_path)
         self._validate_environment(project=config["project"], modules=config["modules"])
 
-        mkdir(internal.SRC_DIR, exist_ok=True, verbose=True)
+        mkdir(internal.SRC_DIR, exist_ok=True)
 
-        print("Checking out repositories...")
+        self.logger.info("Checking out repositories...")
         rev_number_log = ""
+
         for model in self._get_models(config):
-            model.repo.checkout(verbose=verbose)
+            model.repo.checkout()
             rev_number_log += f"{model.name}: {model.repo.get_revision()}\n"
 
         rev_number_log_path = next_path("rev_number-*.log")
-        print(f"Writing revision number info to {rev_number_log_path}")
+        self.logger.info(f"Writing revision number info to {rev_number_log_path}")
         with rev_number_log_path.open("w", encoding="utf-8") as file:
             file.write(rev_number_log)
 
-        print("")
-
-    def build(self, config_path: str, verbose: bool):
+    def build(self, config_path: str):
         """Endpoint for `benchcab build`."""
         config = self._get_config(config_path)
         self._validate_environment(project=config["project"], modules=config["modules"])
 
         for repo in self._get_models(config):
             if repo.build_script:
-                print(
-                    "Compiling CABLE using custom build script for "
-                    f"realisation {repo.name}..."
-                )
-                repo.custom_build(modules=config["modules"], verbose=verbose)
+
+                self.logger.info("Compiling CABLE using custom build script for")
+                self.logger.info(f"realisation {repo.name}")
+                repo.custom_build(modules=config["modules"])
+
             else:
                 build_mode = "with MPI" if internal.MPI else "serially"
-                print(f"Compiling CABLE {build_mode} for realisation {repo.name}...")
-                repo.pre_build(verbose=verbose)
-                repo.run_build(modules=config["modules"], verbose=verbose)
-                repo.post_build(verbose=verbose)
-            print(f"Successfully compiled CABLE for realisation {repo.name}")
-        print("")
-
-    def fluxsite_setup_work_directory(self, config_path: str, verbose: bool):
+                self.logger.info(
+                    f"Compiling CABLE {build_mode} for realisation {repo.name}..."
+                )
+                repo.pre_build()
+                repo.run_build(modules=config["modules"])
+                repo.post_build()
+            self.logger.info(f"Successfully compiled CABLE for realisation {repo.name}")
+
+    def fluxsite_setup_work_directory(self, config_path: str):
         """Endpoint for `benchcab fluxsite-setup-work-dir`."""
         config = self._get_config(config_path)
         self._validate_environment(project=config["project"], modules=config["modules"])
 
         tasks = self.tasks if self.tasks else self._initialise_tasks(config)
-        print("Setting up run directory tree for fluxsite tests...")
-        setup_fluxsite_directory_tree(verbose=verbose)
-        print("Setting up tasks...")
+        self.logger.info("Setting up run directory tree for fluxsite tests...")
+        setup_fluxsite_directory_tree()
+        self.logger.info("Setting up tasks...")
         for task in tasks:
-            task.setup_task(verbose=verbose)
-        print("Successfully setup fluxsite tasks")
-        print("")
+            task.setup_task()
+        self.logger.info("Successfully setup fluxsite tasks")
 
-    def fluxsite_run_tasks(self, config_path: str, verbose: bool):
+    def fluxsite_run_tasks(self, config_path: str):
         """Endpoint for `benchcab fluxsite-run-tasks`."""
         config = self._get_config(config_path)
         self._validate_environment(project=config["project"], modules=config["modules"])
 
         tasks = self.tasks if self.tasks else self._initialise_tasks(config)
-        print("Running fluxsite tasks...")
+        self.logger.info("Running fluxsite tasks...")
         if config["fluxsite"]["multiprocess"]:
             ncpus = config["fluxsite"]["pbs"]["ncpus"]
-            run_tasks_in_parallel(tasks, n_processes=ncpus, verbose=verbose)
+            run_tasks_in_parallel(tasks, n_processes=ncpus)
         else:
-            run_tasks(tasks, verbose=verbose)
-        print("Successfully ran fluxsite tasks")
-        print("")
+            run_tasks(tasks)
+        self.logger.info("Successfully ran fluxsite tasks")
 
-    def fluxsite_bitwise_cmp(self, config_path: str, verbose: bool):
+    def fluxsite_bitwise_cmp(self, config_path: str):
         """Endpoint for `benchcab fluxsite-bitwise-cmp`."""
         config = self._get_config(config_path)
         self._validate_environment(project=config["project"], modules=config["modules"])
@@ -280,32 +288,30 @@
         tasks = self.tasks if self.tasks else self._initialise_tasks(config)
         comparisons = get_fluxsite_comparisons(tasks)
 
-        print("Running comparison tasks...")
+        self.logger.info("Running comparison tasks...")
         if config["fluxsite"]["multiprocess"]:
             ncpus = config["fluxsite"]["pbs"]["ncpus"]
-            run_comparisons_in_parallel(comparisons, n_processes=ncpus, verbose=verbose)
+            run_comparisons_in_parallel(comparisons, n_processes=ncpus)
         else:
-            run_comparisons(comparisons, verbose=verbose)
-        print("Successfully ran comparison tasks")
+            run_comparisons(comparisons)
+        self.logger.info("Successfully ran comparison tasks")
 
-    def fluxsite(
-        self, config_path: str, no_submit: bool, verbose: bool, skip: list[str]
-    ):
+    def fluxsite(self, config_path: str, no_submit: bool, skip: list[str]):
         """Endpoint for `benchcab fluxsite`."""
-        self.checkout(config_path, verbose)
-        self.build(config_path, verbose)
-        self.fluxsite_setup_work_directory(config_path, verbose)
+        self.checkout(config_path)
+        self.build(config_path)
+        self.fluxsite_setup_work_directory(config_path)
         if no_submit:
-            self.fluxsite_run_tasks(config_path, verbose)
+            self.fluxsite_run_tasks(config_path)
             if "fluxsite-bitwise-cmp" not in skip:
-                self.fluxsite_bitwise_cmp(config_path, verbose)
+                self.fluxsite_bitwise_cmp(config_path)
         else:
-            self.fluxsite_submit_job(config_path, verbose, skip)
+            self.fluxsite_submit_job(config_path, skip)
 
-    def spatial(self, config_path: str, verbose: bool):
+    def spatial(self, config_path: str):
         """Endpoint for `benchcab spatial`."""
 
-    def run(self, config_path: str, no_submit: bool, verbose: bool, skip: list[str]):
+    def run(self, config_path: str, no_submit: bool, skip: list[str]):
         """Endpoint for `benchcab run`."""
-        self.fluxsite(config_path, no_submit, verbose, skip)
-        self.spatial(config_path, verbose)
+        self.fluxsite(config_path, no_submit, skip)
+        self.spatial(config_path)