Added set -ex to the jobscript rendering, removed if statements. Fixe… #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage ? 88.77%
=======================================
Files ? 27
Lines ? 1630
Branches ? 0
=======================================
Hits ? 1447
Misses ? 183
Partials ? 0 |
ccarouge
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added set -ex to the header of the rendered jobscript. -x is used in place of explicit error messages as per the removed if statements, as it outputs all commands as they are being called so that we can see the exact line that the script fails.
In resolving this, the tests appear to be a bit flakey, relying on specific whitespace and line endings. I think this will be resolved as we move to Jinja2 templating (#142)
Fixes #158.