Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up code #166

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Tidy up code #166

merged 2 commits into from
Oct 5, 2023

Conversation

ccarouge
Copy link
Member

@ccarouge ccarouge commented Oct 5, 2023

Fixes #149

  • Moved next_path() to fs.py
  • Change assert all() to individual assert on each dictionary item. I have checked if the test fails the failure message states the individual item.

@ccarouge ccarouge linked an issue Oct 5, 2023 that may be closed by this pull request
@ccarouge ccarouge marked this pull request as draft October 5, 2023 01:01
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@162f554). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage        ?   88.77%           
=======================================
  Files           ?       26           
  Lines           ?     1631           
  Branches        ?        0           
=======================================
  Hits            ?     1448           
  Misses          ?      183           
  Partials        ?        0           

@ccarouge ccarouge marked this pull request as ready for review October 5, 2023 01:13
@ccarouge ccarouge changed the title #149- Tidy up code Tidy up code Oct 5, 2023
@ccarouge ccarouge merged commit de33ae0 into main Oct 5, 2023
@ccarouge ccarouge deleted the 149-general-tidy-up-of-code branch October 5, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General tidy up of code.
2 participants