Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getter for executable path in CableRepository #199

Closed
Tracked by #183
SeanBryan51 opened this issue Nov 6, 2023 · 0 comments · Fixed by #206
Closed
Tracked by #183

Add getter for executable path in CableRepository #199

SeanBryan51 opened this issue Nov 6, 2023 · 0 comments · Fixed by #206
Assignees
@SeanBryan51

Comments

@SeanBryan51
Copy link
Collaborator

SeanBryan51 commented Nov 6, 2023 •
edited
Loading

Should we eventually have the build set this path and use a getter function here? Same for fluxsite obviously and not for this PR.

Originally posted by @ccarouge in #136 (comment)
@SeanBryan51 SeanBryan51 mentioned this issue Nov 6, 2023
Merged
@SeanBryan51 SeanBryan51 mentioned this issue Nov 16, 2023
Closed
3 tasks
@SeanBryan51 SeanBryan51 self-assigned this Nov 17, 2023
SeanBryan51 added a commit that referenced this issue Nov 17, 2023
@SeanBryan51
Add getter method for built executable
74bee79 
This change removes any hard coded paths to the built executable that
are outside the `CableRepository` class and replaces these with a method
that returns the path to the executable. This is done to prepare for the
changes in #183 which requires paths to vary accross different
`CableRepository` objects.

Fixes #199
@SeanBryan51 SeanBryan51 mentioned this issue Nov 17, 2023
Merged
@SeanBryan51 SeanBryan51 linked a pull request Nov 17, 2023 that will close this issue
Add getter method for built executable #206
Merged
SeanBryan51 added a commit that referenced this issue Nov 19, 2023
@SeanBryan51
Add getter method for built executable
e9110fa 
This change removes any hard coded paths to the built executable that
are outside the `CableRepository` class and replaces these with a method
that returns the path to the executable. This is done to prepare for the
changes in #183 which requires paths to vary accross different
`CableRepository` objects.

Fixes #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanBryan51 SeanBryan51

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add getter method for built executable CABLE-LSM/benchcab
1 participant
@SeanBryan51