Add sftp client close #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly 10 seconds after connecting unless reset by calling some server request action. This should solve for bug where connections remain open forever in long-lived app.
funkyshu
requested review from
seeroush,
dmcilvain44,
atulbhadouria and
arnab-chaudhuri-c2fo
funkyshu
commented
Aug 21, 2021
| _ = fs.sftpclient.Close() | ||
| fs.sftpclient = nil | ||
| } | ||
| }) |
There was a problem hiding this comment.
This ends up being the meat of the changes. This timer will disconnect after 10 seconds (default) unless a new request to the server is made (read, write, list, etc), in which case the timer will reset.
If a timer expires and closes a connection, any subsequent server request action will request a new client, reconnecting and starting new timer.
In this way, a user need not explicit call Close on a client since it will simply timeout anyway.
arnab-chaudhuri-c2fo
approved these changes
Aug 21, 2021
atulbhadouria
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #84 where sftp connections were never disconnected in a long-lived app.
Added Close to sftp backend Client interface.
Close client automatically 10 seconds (configurable in Options) after connecting unless reset by calling some server request action.