Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-2061 -> master | Prep vfs for opensource #5

Merged
merged 16 commits into from
Jan 17, 2019
Merged

EP-2061 -> master | Prep vfs for opensource #5

merged 16 commits into from
Jan 17, 2019

Conversation

funkyshu
Copy link
Member

@funkyshu funkyshu commented Jan 8, 2019

JIRA Link

Description

Our golang vfs library was built with the intention of releasing as opensource. We held off until we could make it prettier and more features but after more than a year in production and only minor changes, we still have yet to release it. Since then google has release a clould agnostic swiss army knife library call go-cloud that implements some vfs-type functionality but nowhere near as full-featured.

We should prep VFS code for public release. Some steps include:

  • -Ensuring vfs works with the latest third party libs (google-sdk, aws-sdk, etc)- Unsafe to do this until we upgrade to 1.11
  • Ensure docs are up-to-date
  • Consider setting up go.mod (vgo) and/or dep (can these coexist with glide files?)
  • Clean repo? (there are one or two commit messages that contain Jira ticket info).
  • Get sign-off from SecOps and JC
  • Make repo public
    There may be other items i haven't considered.

Test Steps

Put your test steps here....

@funkyshu
Copy link
Member Author

@jkc Are we good on this? You only commented.

@funkyshu funkyshu requested a review from jonstacks January 15, 2019 22:56
@jkc
Copy link
Contributor

jkc commented Jan 16, 2019

Looking now. I just posted the comment because that's as far as I got, and had to get back to working with Aaron on my test environment.

@funkyshu funkyshu merged commit adcf826 into master Jan 17, 2019
@funkyshu funkyshu deleted the v2 branch January 17, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants