-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP-2061 -> master | Prep vfs for opensource #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeroush
suggested changes
Jan 8, 2019
seeroush
approved these changes
Jan 8, 2019
jkc
reviewed
Jan 10, 2019
…mock to match interface of current aws-sdk.
@jkc Are we good on this? You only commented. |
Looking now. I just posted the comment because that's as far as I got, and had to get back to working with Aaron on my test environment. |
jkc
reviewed
Jan 16, 2019
jkc
reviewed
Jan 16, 2019
jkc
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link
Description
Our golang vfs library was built with the intention of releasing as opensource. We held off until we could make it prettier and more features but after more than a year in production and only minor changes, we still have yet to release it. Since then google has release a clould agnostic swiss army knife library call go-cloud that implements some vfs-type functionality but nowhere near as full-featured.
We should prep VFS code for public release. Some steps include:
There may be other items i haven't considered.
Test Steps
Put your test steps here....