Change A Lot Of Emojis

[Bronnel721]

I know this is a lot, but I feel that I should update some of them. Apologies if it adds files instead of updating them. By the way, what is the disguised face based on?

[Bronnel721]

@C1710, are you procrastinating?

[C1710]

I looked at them yesterday and I agree with most changes.
I'm not sure though about changing the color of drops (like for '😅') to blue. I understand why this change makes sense, but I'm not sure about it yet.

I'm not at home right now, so I can't give you more details at the moment.

[Bronnel721]

If you'd like to, you, or I, can change the color back to white, but honestly, I don't know if that's a good idea.

[C1710]

If you'd like to, you, or I, can change the color back to white, but honestly, I don't know if that's a good idea.

If it's alright with you I would wait a bit before merging to give others a chance to add some opinions (if anyone has any).
I'll probably only include it with the 15.1 release anyway.

[C1710]

The disguised face is based on SpongeBob posing as Squidward, plus glasses; although when I come to think about it, I can't remember exactly, which scene it was based on. To be honest, it's not a very good design and it would make sense to adapt the Noto one instead 😅

[Bronnel721]

I'll probably only include it with the 15.1 release anyway.

Are you talking about the drop color or the whole changes that I've made in general?

[C1710]

I'll probably only include it with the 15.1 release anyway.
Are you talking about the drop color or the whole changes that I've made in general?

No, I'm talking about everything, as it's all one PR. I mean, I could try to add the other changes first (not sure right now how that would work), but i don't think I will build a new font with it directly.

[Bronnel721]

I mean, I could try to add the other changes first (not sure right now how that would work), but i don't think I will build a new font with it directly.

Then how will you do it? Also, did you post the same comment twice?

[C1710]

I mean, I could try to add the other changes first (not sure right now how that would work), but i don't think I will build a new font with it directly.

I mean, I'll rebuild the font only with the next release or so.

Then how will you do it? Also, did you post the same comment twice?

The mobile internet connection in this train is pretty bad, so probably yes 😂

[Bronnel721]

I mean, I'll rebuild the font only with the next release or so.

So you are saying that in releases after that, you won't use the ones that I designed?

[C1710]

I mean, I'll rebuild the font only with the next release or so.

So you are saying that in releases after that, you won't use the ones that I designed?

I just wanted to say that I won't use them before that release 😅

[Bronnel721]

Are you talking about the 15.1 release?

[C1710]

Are you talking about the 15.1 release?

Yes, so my plan is:
Maybe like next week or so I'm planning to do the first beta release with the new emojis from Emoji 15.1 (emojis facing to the other side, phoenix, lime, etc.) and that is supposed to be the first release with your changes as well.

Additionally I'm thinking about reverting the file names to all be emoji_u... again as it's easier to use them with the Noto-based toolsets, but if I do that I'll make that change after I merged your PR, so you don't have to do anything about that.

[Bronnel721]

Okay. Hope this goes well!

[Secret-chest]

Most changes look good to me, however:

• The human emojis should not be changed since the style in Noto is different from the style we use here.
• Just my opinion, but the faces with teeth were cute. Additionally, in u1f601, the mouth looks too round.
• In Japan, drops are traditionally depicted in white, and this is a defining feature of the original emoji set.
• I liked u1f628's bigger mouth more.
• u1f62d's tears should be changed to streams. This would be an exception, to make the pond visible, the streams and pond would be a white to dark blue gradient.
• The u1f92e should be green, other vendors do that too.
• I liked the old u1f958 more, also we use blue-grey, not grey to represent metal here.
• u1f95e should keep the plate.
• The old melting face was more melty imo.
• The new saluting face is just stupid, doesn't look like a hand, revert.

Other changes are fine.

[Secret-chest]

@C1710 also, if you do merge these, please correct the palette as most of them look copied straight from Noto

[C1710]

I tried to "resolve conflicts" and that didn't work. 😬

Don't worry, I'll look at it tomorrow 😅

[Bronnel721]

If they will be broken forever, here's the ZIP file:
Emojis.zip
I hope this works.

[Bronnel721]

How do you stop yourself from merging the files?

[C1710]

If they will be broken forever, here's the ZIP file: Emojis.zip I hope this works.

That's actually the one nice thing about Git: Nothing is lost. We can revert that broken merge and then fix it. But not today anymore :D

[Bronnel721]

Also, when I installed the fork, the SVGs looked normal.

[Bronnel721]

Can you only revert that commit or will it affect the other commits?

[Bronnel721]

@C1710, I saw the SVGs on GitHub and they don't look broken, but the commit still thinks it's broken. Does that still mean that the files are broken?

[Bronnel721]

I made some changes. Do you think they're better?

[Bronnel721]

@C1710, I know that you are probably busy, but please respond.

[C1710]

I fixed it now and applied some of the newer changes, but I think at this point you shouldn't add more stuff. This PR is already pretty large and hard to handle.
I'm now trying to figure out how to apply the fixes to this PR...

[Bronnel721]

If it's too large, I'll send you a ZIP file with ALL the changes.

[C1710]

If it's too large, I'll send you a ZIP file with ALL the changes.

I meant there are already many changes at this point, you shouldn't add even more. It just makes it messier.

[Bronnel721]

I'm not gonna add anymore.

[C1710]

I have the fixes on https://github.com/C1710/blobmoji/tree/emoji15.1-sayhone (plus I reverted the updates that I do not want to add).

I don't know what's the best way to do the PR (maybe I open one and reference this one? You're still listed as the author/person that made the commits) and I don't have enough time for that at the moment.

[Bronnel721]

Why is there a bitmap in emoji_u1f600.svg?

[C1710]

Why is there a bitmap in emoji_u1f600.svg?

I'm not sure. Could be a mistake from an export. Affinity Designer (the software I use) often makes bitmaps out of features that it can't export to SVG. I usually don't use those but it might be possible, that there was a mistake there. I can fix that later (or tomorrow or so) though.

[Bronnel721]

Okay, try to change the teeth to fit with the other emojis that have teeth, like this:

[C1710]

I made a new PR based on the branch with the fixes and color corrections: #133.
It just seemed easier for me to do it that way.

[Bronnel721]

I like these color changes.