Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Improve arrow navigation #99

Merged
merged 4 commits into from
Dec 7, 2021
Merged

Conversation

MathisFederico
Copy link
Member

Now navigation also triggers selection on the current block, this will make a lot a sense when #91 will be merged.
Also refactors navigation because infinity norm felt non-natural in some edges cases.

@MathisFederico MathisFederico requested a review from vanyle December 7, 2021 19:36
Copy link
Contributor

@vanyle vanyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment update at it will be good !

opencodeblocks/graphics/view.py Outdated Show resolved Hide resolved
opencodeblocks/graphics/view.py Show resolved Hide resolved
@MathisFederico MathisFederico requested a review from vanyle December 7, 2021 20:43
@MathisFederico MathisFederico merged commit fbaca4a into master Dec 7, 2021
@MathisFederico MathisFederico deleted the feature/selection_navigation branch December 7, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants