Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Functional flow execution #98

Merged
merged 7 commits into from
Dec 6, 2021
Merged

Conversation

AlexandreSajus
Copy link
Contributor

@AlexandreSajus AlexandreSajus commented Dec 6, 2021

A code block now has two buttons:

  • Left run: will run the block and all of its dependencies in the right order
  • Right run: will run the block's outputs and all of their dependencies in the right order

This is done through an execution queue and graph traversal utilities

Closes #48
Closes #25 executing two blocks at the same time will now create a queue

Still lacks:

  • testing (testing can be done manually using the two added examples and the modified mnist)
  • not running a cell when it has been run and was not modified

@AlexandreSajus AlexandreSajus added the enhancement New feature or request label Dec 6, 2021
@AlexandreSajus AlexandreSajus self-assigned this Dec 6, 2021
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add block.has_ran property and refactor

opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Outdated Show resolved Hide resolved
opencodeblocks/blocks/codeblock.py Show resolved Hide resolved
@MathisFederico MathisFederico merged commit 21fc775 into master Dec 6, 2021
@MathisFederico MathisFederico deleted the feature/flow_execution branch December 6, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execution Flow Executing a block while another one is running crashes the application
2 participants