Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced autoscroll & Tests refactor #77

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

MathisFederico
Copy link
Member

No description provided.

@vanyle
Copy link
Contributor

vanyle commented Nov 29, 2021

For now, I don't think that moving:

        self.window = OCBWindow()
        self.ocb_widget = OCBWidget()
        self.subwindow = self.window.mdiArea.addSubWindow(self.ocb_widget)
        self.subwindow.show()

into a utils function makes sense. It might be needed if the setup gets more complicated.
In this case, We'll have to use inheritance for test classes.

More robusteness for the dragging test will be needed in the future but this is another issue.

@MathisFederico
Copy link
Member Author

For now, I don't think that moving:

        self.window = OCBWindow()
        self.ocb_widget = OCBWidget()
        self.subwindow = self.window.mdiArea.addSubWindow(self.ocb_widget)
        self.subwindow.show()

into a utils function makes sense. It might be needed if the setup gets more complicated. In this case, We'll have to use inheritance for test classes.

I don't get it, this code is not in utils, it's in test files directly

@vanyle
Copy link
Contributor

vanyle commented Nov 29, 2021

For now, I don't think that moving this code into a utils function makes sense. (I'm referencing the fact that codacy says this is a duplicate but 4 duplicated lines are not enough to be worth a refactor yet.), so it's fine.

@MathisFederico MathisFederico merged commit 5516a5c into master Nov 29, 2021
@MathisFederico MathisFederico deleted the feature/advanced_autoscroll branch November 29, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants