Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 The arrows allow the user to navigate from block to block #74

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

vanyle
Copy link
Contributor

@vanyle vanyle commented Nov 28, 2021

This resolves #64

Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !

# x or y has the correct sign (depends on the key pressed)

dist_array = []
for block in code_blocks:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we might want to only look at close blocks


key_id = event.key()
items = self.scene().items()
code_blocks = [i for i in items if isinstance(i, OCBBlock)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocks in a more general name, as text blocks and so on might be in there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will edit this in the pull request that resolves #28

@vanyle vanyle merged commit e8a05fb into master Nov 28, 2021
@vanyle vanyle deleted the feature/arrow_navigation branch November 28, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block navigation
2 participants