Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Feature/socket flow type #59

Merged
merged 4 commits into from
Nov 22, 2021
Merged

🎉 Feature/socket flow type #59

merged 4 commits into from
Nov 22, 2021

Conversation

MathisFederico
Copy link
Member

@MathisFederico MathisFederico commented Nov 21, 2021 •
edited
Loading

Add flow_type as a socket attribute modifying socket shape. Closes #47
Prevent user from building edges backward when flow_type is 'exe' (for execution)

@MathisFederico MathisFederico self-assigned this Nov 21, 2021
AlexandreSajus
AlexandreSajus approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@AlexandreSajus AlexandreSajus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any major problems, although I don't really understand what is achieved here, approved

@AlexandreSajus AlexandreSajus merged commit 1ac5c0b into master Nov 22, 2021
@MathisFederico MathisFederico deleted the feature/socket_flow_type branch November 28, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreSajus AlexandreSajus AlexandreSajus approved these changes

Assignees

@MathisFederico MathisFederico

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket flowtype
2 participants
@MathisFederico @AlexandreSajus